This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Add SchemaJsonFormat check #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
force-pushed
the
feature/json-format-check
branch
from
c125882 to
c2a0d86
Compare
charlespwd
force-pushed
the
feature/json-format-check
branch
from
c2a0d86 to
68780c8
Compare
macournoyer
approved these changes
Nov 26, 2021
| @@ -166,6 +171,10 @@ def block? | |||
| block_tag? || block_body? || document? | |||
| end | |||
|
|
|||
| def schema? | |||
| @value.is_a?(ThemeCheck::Tags::Schema) | |||
There was a problem hiding this comment.
I think that won't work when ThemeCheck is running in Core or SFR
There was a problem hiding this comment.
Why not? It's our namespace? Didn't we copy the code over?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json-formatting.mp4
Fixes #16