This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Properly shutdown language server #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macournoyer
approved these changes
Sep 27, 2021
charlespwd
force-pushed
the
fix/properly-shutdown-language-server
branch
2 times, most recently
from
7f75900 to
f9c308c
Compare
$DEBUG is a standard ruby flag. It also logs all exceptions to STDERR. When using the language server with this option, things were weird in the logs pane. Since stuff kept getting logged even though the server was closing and the exceptions were being caught. This resulted in logs that stayed around instead of going away. Took me way too long to figure that out. By moving to ThemeCheck.debug? instead, this doesn't happen anymore.
result: null is a valid response (used in Shutdown exchange)
The shutdown -> exit loop makes it so the logs are properly cleaned up in VS Code. Oops.
charlespwd
force-pushed
the
fix/properly-shutdown-language-server
branch
from
f9c308c to
694e14b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the process for closing the server is two messages.
If we're not doing the exit, VS Code doesn't clear the logs. That's why we were getting multiple instances of Theme Check Language Server when restarting the server in VS Code.
Ooops!
https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#shutdown
Also, I changed
$DEBUGtoTHEME_CHECK_DEBUG.$DEBUGhas a special meaning in ruby and it logs all exception to STDERR. EVEN WHEN CAUGHT! It took me a while to figure out why the vs code logs were not disappearing. Turns out I had enabled that (because I setTHEME_CHECK_DEBUGto true in my environment).Also, now, instead of crashing the server, errors raised in a request handler will be sent back as an internal error.
This means you can keep having completions even when diagnostics are breaking and vice versa.