Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Auto-fix json translates json files to Ruby hash #432

Closed
kyran-edn opened this issue Sep 8, 2021 · 2 comments · Fixed by #434
Closed

Auto-fix json translates json files to Ruby hash #432

kyran-edn opened this issue Sep 8, 2021 · 2 comments · Fixed by #434
Labels
bug Something isn't working p:high Priority (or Impact): High

Comments

@kyran-edn
Copy link

Running: theme-check --exclude-category liquid -a modifies / converts all json files to what I believe is a Ruby hash.

Before:

{
    "name": "Search",
    "sections": {
        "template-search": {
            "type": "template-search"
        }
    },
    "order": [
        "template-search"
    ]
}

After:

{"name"=>"Search", "sections"=>{"template-search"=>{"type"=>"template-search"}}, "order"=>["template-search"]}

Don't think this is intended, please let me know if it is intended.

@illarionvk
Copy link

I have the same issue with Theme Check 1.2.0 in Shopify CLI 2.3.0. Theme Check converts all JSON files in the working folder to Ruby Hashes if the --auto-correct flag is set.

theme-check-overwrites-json-files

@charlespwd
Copy link
Contributor

Not intended. Will fix this ASAP.

charlespwd added a commit that referenced this issue Sep 9, 2021
@charlespwd charlespwd added bug Something isn't working p:high Priority (or Impact): High labels Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working p:high Priority (or Impact): High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants