Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Autocorrection TranslationKeyExists #422

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

hannakebedom
Copy link
Contributor

@hannakebedom hannakebedom commented Sep 1, 2021

What does this do?

Prevents translation errors in themes.

How does it do it?

Adds missing translation keys to locale files

Why did you pick this approach over other options?

This approach uses methods on the corrector class to add key-value pairs to existing JSON locale files

@hannakebedom hannakebedom force-pushed the auto_correct_translation_key_exists branch from b7ec369 to dab60b1 Compare September 2, 2021 16:15
@hannakebedom hannakebedom changed the title WIP Autocorrection TranslationKeyExists Autocorrection TranslationKeyExists Sep 2, 2021
@hannakebedom hannakebedom force-pushed the auto_correct_translation_key_exists branch from 33f0e84 to a7498c4 Compare September 2, 2021 16:24
@hannakebedom hannakebedom marked this pull request as ready for review September 2, 2021 16:27
Copy link
Contributor

@macournoyer macournoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Very useful stuff. 👏

@hannakebedom hannakebedom force-pushed the auto_correct_translation_key_exists branch from dc5b241 to 0b570d1 Compare September 13, 2021 20:55
@hannakebedom hannakebedom merged commit d25128c into main Sep 14, 2021
@hannakebedom hannakebedom deleted the auto_correct_translation_key_exists branch September 14, 2021 13:28
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems September 14, 2021 20:30 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants