Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Autocorrection UnusedAssign #380

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Autocorrection UnusedAssign #380

merged 2 commits into from
Nov 9, 2021

Conversation

hannakebedom
Copy link
Contributor

@hannakebedom hannakebedom commented Aug 4, 2021 •
edited
Loading

What does this do?

Prevents bloat in themes by removing variable definitions that are not used.

How does it do it?

Removes unused variable definitions.

Why did you pick this approach over other options?

Automatically removing unused variable definitions is convenient & easy for users.

@hannakebedom hannakebedom force-pushed the auto_correct_unused_assign branch from 73920a1 to 6a5a994 Compare August 8, 2021 01:41
@hannakebedom hannakebedom marked this pull request as ready for review August 9, 2021 14:45
macournoyer
macournoyer reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@macournoyer macournoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it won't work if the line contains more then the assign, but I might be wrong.

@hannakebedom hannakebedom changed the title Autocorrection UnusedAssign WIP Autocorrection UnusedAssign Aug 30, 2021
@hannakebedom hannakebedom marked this pull request as draft August 30, 2021 13:37
charlespwd
charlespwd reviewed Sep 13, 2021
View reviewed changes
@hannakebedom hannakebedom force-pushed the auto_correct_unused_assign branch 2 times, most recently from 0c0ff99 to db33910 Compare October 8, 2021 19:15
@hannakebedom hannakebedom force-pushed the auto_correct_unused_assign branch 2 times, most recently from 7f08d61 to bac731c Compare October 19, 2021 15:19
@hannakebedom hannakebedom changed the title WIP Autocorrection UnusedAssign Autocorrection UnusedAssign Oct 19, 2021
@hannakebedom hannakebedom marked this pull request as ready for review October 19, 2021 15:24
macournoyer
macournoyer approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@macournoyer macournoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👏

@hannakebedom hannakebedom force-pushed the auto_correct_unused_assign branch from bac731c to fc23853 Compare November 5, 2021 17:37
@hannakebedom hannakebedom force-pushed the auto_correct_unused_assign branch from fc23853 to dca0936 Compare November 5, 2021 17:47
@hannakebedom hannakebedom merged commit 9a4d2ac into main Nov 9, 2021
@hannakebedom hannakebedom deleted the auto_correct_unused_assign branch November 9, 2021 16:53
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems November 9, 2021 18:20 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlespwd charlespwd charlespwd left review comments

@macournoyer macournoyer macournoyer approved these changes

@tristan-potter tristan-potter tristan-potter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannakebedom @macournoyer @tristan-potter @charlespwd