This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Add Windows support #364
Merged
Add Windows support #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
charlespwd
commented
Jul 14, 2021
charlespwd
commented
- Add Windows support to the language server (prep work for Shopify/theme-check-vscode#5)
- Add Windows executables
jmignac
approved these changes
Jul 15, 2021
| @@ -99,7 +99,7 @@ def text_document_uri(params) | |||
| end | |||
|
|
|||
| def path_from_uri(uri) | |||
| uri&.sub('file://', '') | |||
| uri&.sub('file://', '')&.sub('/c%3A', '') | |||
There was a problem hiding this comment.
don't you really want .chomp? Or are you expecting \r in the middle of the string?
There was a problem hiding this comment.
It's the c:/ that I'm stripping. Not sure that applies?
| # | ||
| # Hours wasted: 8. | ||
| eol = Gem.win_platform? ? "\n" : "\r\n" | ||
| @out.write("Content-Length: #{response_body.bytesize}#{eol}") |
There was a problem hiding this comment.
for clarity, I'd suggest breaking out the line termination from the http header name/value pair. also, any concern that the bytesize will be null? If so, I'd want to add a safety here. (I'm guessing not since the response_body is fully buffered?
There was a problem hiding this comment.
Yeah the response_body is a JSON.dump. I don't think that's possible unless you explicitly call send_response without arguments.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.