Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Directories with spaces or special characters doesn't seem to run #360

Closed
sb18281 opened this issue Jul 7, 2021 · 0 comments · Fixed by #382
Closed

Directories with spaces or special characters doesn't seem to run #360

sb18281 opened this issue Jul 7, 2021 · 0 comments · Fixed by #382
Assignees
Labels
bug Something isn't working e:2 Effort: 2

Comments

@sb18281
Copy link

sb18281 commented Jul 7, 2021

Issue

When trying to run the extension in a workspace where the folder structure contains spaces or special characters (i.e "Documents/Hello There" or "Documents/Hello & There". The theme check extension seems to run, but doesn't produce any errors.

image

When running shopify theme check it correctly produces errors in the terminal.

When running the extension on another directory with no spaces or special characters, it runs as expected.

image

Machine Info

Shopify cli version 2.0.1
Extension version 1.0.1

Ubuntu 20.04.2 LTS

**VS Code **
Version: 1.57.1
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:26:56.255Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Linux x64 5.8.0-59-generic snap

@charlespwd charlespwd transferred this issue from Shopify/theme-check-vscode Jul 12, 2021
@charlespwd charlespwd added the bug Something isn't working label Jul 15, 2021
@charlespwd charlespwd added the e:2 Effort: 2 label Jul 15, 2021
@charlespwd charlespwd self-assigned this Aug 9, 2021
charlespwd added a commit that referenced this issue Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working e:2 Effort: 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants