From 125252e219fcbe5cbcb20d9822404047085c0d86 Mon Sep 17 00:00:00 2001 From: ICHINOSE Shogo Date: Wed, 6 Sep 2023 09:25:13 +0900 Subject: [PATCH 1/5] bump Node.js v20 --- action.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/action.yml b/action.yml index ff98e46f..a9e938a6 100644 --- a/action.yml +++ b/action.yml @@ -1,33 +1,33 @@ -name: 'Yet Another Upload Release Asset Action' -description: 'Yet Another Upload Release Asset Action' -author: 'Ichinose Shogo' +name: "Yet Another Upload Release Asset Action" +description: "Yet Another Upload Release Asset Action" +author: "Ichinose Shogo" inputs: github_token: - description: 'The API token for GitHub' + description: "The API token for GitHub" required: true default: "${{ github.token }}" upload_url: - description: 'The URL for uploading assets to the release' + description: "The URL for uploading assets to the release" required: true asset_path: - description: 'The path to the asset you want to upload' + description: "The path to the asset you want to upload" required: true asset_name: - description: 'The name of the asset you want to upload' + description: "The name of the asset you want to upload" required: false asset_content_type: - description: 'The content-type of the asset you want to upload. See the supported Media Types here: https://www.iana.org/assignments/media-types/media-types.xhtml for more information' + description: "The content-type of the asset you want to upload. See the supported Media Types here: https://www.iana.org/assignments/media-types/media-types.xhtml for more information" required: false overwrite: - description: 'If an asset with the same name already exists, overwrite it (Default: false)' + description: "If an asset with the same name already exists, overwrite it (Default: false)" required: false default: false outputs: browser_download_url: - description: 'The URL users can navigate to in order to download the uploaded asset' + description: "The URL users can navigate to in order to download the uploaded asset" runs: - using: 'node16' - main: 'dist/index.js' + using: "node20" + main: "dist/index.js" branding: - icon: 'package' - color: 'gray-dark' + icon: "package" + color: "gray-dark" From 03e5122e1d0ce1ab93a779d42a53dfd61304cd3a Mon Sep 17 00:00:00 2001 From: ICHINOSE Shogo Date: Wed, 6 Sep 2023 09:32:12 +0900 Subject: [PATCH 2/5] bump @types/node v20.5.9 --- .github/dependabot.yml | 7 +++++-- package-lock.json | 14 +++++++------- package.json | 2 +- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 3e00517c..f91b1a0f 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -9,9 +9,12 @@ updates: interval: "daily" open-pull-requests-limit: 10 ignore: - # update too often, ignore patch releases - dependency-name: "@types/node" - update-types: ["version-update:semver-patch"] + update-types: + # major version must sync with nodejs version + - "version-update:semver-major" + # update too often, ignore patch releases + - "version-update:semver-patch" # Maintain dependencies for GitHub Actions - package-ecosystem: "github-actions" diff --git a/package-lock.json b/package-lock.json index 8a417a6e..ab1aabbb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -17,7 +17,7 @@ "devDependencies": { "@types/jest": "^29.5.4", "@types/mime-types": "^2.1.1", - "@types/node": "^16.18.3", + "@types/node": "^20.5.9", "@typescript-eslint/parser": "^5.62.0", "@zeit/ncc": "^0.22.3", "eslint": "^8.48.0", @@ -1349,9 +1349,9 @@ "dev": true }, "node_modules/@types/node": { - "version": "16.18.3", - "resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.3.tgz", - "integrity": "sha512-jh6m0QUhIRcZpNv7Z/rpN+ZWXOicUUQbSoWks7Htkbb9IjFQj4kzcX/xFCkjstCj5flMsN8FiSvt+q+Tcs4Llg==", + "version": "20.5.9", + "resolved": "https://registry.npmjs.org/@types/node/-/node-20.5.9.tgz", + "integrity": "sha512-PcGNd//40kHAS3sTlzKB9C9XL4K0sTup8nbG5lC14kzEteTNuAFh9u5nA0o5TWnSG2r/JNPRXFVcHJIIeRlmqQ==", "dev": true }, "node_modules/@types/stack-utils": { @@ -6133,9 +6133,9 @@ "dev": true }, "@types/node": { - "version": "16.18.3", - "resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.3.tgz", - "integrity": "sha512-jh6m0QUhIRcZpNv7Z/rpN+ZWXOicUUQbSoWks7Htkbb9IjFQj4kzcX/xFCkjstCj5flMsN8FiSvt+q+Tcs4Llg==", + "version": "20.5.9", + "resolved": "https://registry.npmjs.org/@types/node/-/node-20.5.9.tgz", + "integrity": "sha512-PcGNd//40kHAS3sTlzKB9C9XL4K0sTup8nbG5lC14kzEteTNuAFh9u5nA0o5TWnSG2r/JNPRXFVcHJIIeRlmqQ==", "dev": true }, "@types/stack-utils": { diff --git a/package.json b/package.json index c0b1fdee..084c357c 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,7 @@ "devDependencies": { "@types/jest": "^29.5.4", "@types/mime-types": "^2.1.1", - "@types/node": "^16.18.3", + "@types/node": "^20.5.9", "@typescript-eslint/parser": "^5.62.0", "@zeit/ncc": "^0.22.3", "eslint": "^8.48.0", From 7b884b7d02809c329b27ae76e11c3d9646fd69fb Mon Sep 17 00:00:00 2001 From: ICHINOSE Shogo Date: Wed, 6 Sep 2023 09:32:27 +0900 Subject: [PATCH 3/5] bump Node.js v20 in CI --- .github/workflows/reviewdog.yml | 2 +- .github/workflows/test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 268184ad..c4f94aeb 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -9,7 +9,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16.x" + node-version: "20.x" cache: 'npm' - run: npm ci - uses: reviewdog/action-eslint@v1 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1b7348da..51c6937d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -22,7 +22,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v3 with: - node-version: "16.x" + node-version: "20.x" cache: 'npm' - run: npm ci - run: npm run build @@ -51,7 +51,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v3 with: - node-version: "16.x" + node-version: "20.x" cache: 'npm' - run: npm ci - run: npm run build From 437d595a33353f86ae579842e9e93f778e9e3c1e Mon Sep 17 00:00:00 2001 From: ICHINOSE Shogo Date: Wed, 6 Sep 2023 10:06:47 +0900 Subject: [PATCH 4/5] add .node-version --- .github/workflows/reviewdog.yml | 2 +- .github/workflows/test.yml | 4 ++-- .node-version | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 .node-version diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index c4f94aeb..12525a41 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -9,7 +9,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "20.x" + node-version-file: .node-version cache: 'npm' - run: npm ci - uses: reviewdog/action-eslint@v1 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 51c6937d..f0103ff1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -22,7 +22,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v3 with: - node-version: "20.x" + node-version-file: .node-version cache: 'npm' - run: npm ci - run: npm run build @@ -51,7 +51,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v3 with: - node-version: "20.x" + node-version-file: .node-version cache: 'npm' - run: npm ci - run: npm run build diff --git a/.node-version b/.node-version new file mode 100644 index 00000000..1cc433a1 --- /dev/null +++ b/.node-version @@ -0,0 +1 @@ +20.6.0 From c9697e7e34291bc6bfcf723d3c7dd2be453f9b7a Mon Sep 17 00:00:00 2001 From: ICHINOSE Shogo Date: Wed, 6 Sep 2023 10:11:04 +0900 Subject: [PATCH 5/5] migrate @zeit/ncc to @vercel/ncc --- package-lock.json | 15 +++++++++------ package.json | 2 +- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index ab1aabbb..974c3d8f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19,7 +19,7 @@ "@types/mime-types": "^2.1.1", "@types/node": "^20.5.9", "@typescript-eslint/parser": "^5.62.0", - "@zeit/ncc": "^0.22.3", + "@vercel/ncc": "^0.36.1", "eslint": "^8.48.0", "eslint-plugin-jest": "^27.2.3", "jest": "^29.6.4", @@ -1780,10 +1780,11 @@ "url": "https://opencollective.com/typescript-eslint" } }, - "node_modules/@zeit/ncc": { - "version": "0.22.3", + "node_modules/@vercel/ncc": { + "version": "0.36.1", + "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.36.1.tgz", + "integrity": "sha512-S4cL7Taa9yb5qbv+6wLgiKVZ03Qfkc4jGRuiUQMQ8HGBD5pcNRnHeYM33zBvJE4/zJGjJJ8GScB+WmTsn9mORw==", "dev": true, - "license": "MIT", "bin": { "ncc": "dist/ncc/cli.js" } @@ -6398,8 +6399,10 @@ "eslint-visitor-keys": "^3.0.0" } }, - "@zeit/ncc": { - "version": "0.22.3", + "@vercel/ncc": { + "version": "0.36.1", + "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.36.1.tgz", + "integrity": "sha512-S4cL7Taa9yb5qbv+6wLgiKVZ03Qfkc4jGRuiUQMQ8HGBD5pcNRnHeYM33zBvJE4/zJGjJJ8GScB+WmTsn9mORw==", "dev": true }, "acorn": { diff --git a/package.json b/package.json index 084c357c..ea94b7f1 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,7 @@ "@types/mime-types": "^2.1.1", "@types/node": "^20.5.9", "@typescript-eslint/parser": "^5.62.0", - "@zeit/ncc": "^0.22.3", + "@vercel/ncc": "^0.36.1", "eslint": "^8.48.0", "eslint-plugin-jest": "^27.2.3", "jest": "^29.6.4",