Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports AAC codec multi-channels. #1432

Merged
merged 1 commit into from
May 1, 2024
Merged

Supports AAC codec multi-channels. #1432

merged 1 commit into from
May 1, 2024

Conversation

shogo4405
Copy link
Collaborator

@shogo4405 shogo4405 commented Apr 30, 2024 •
edited
Loading

Description & motivation

  • The AudioCodec class now supports encoding and decoding for 3 channels to 8 channels.

Playback (OBS x HaishinKit)

  1. 2.1
  2. 4.0
  3. 4.1
  4. 5.1 // [19, 176, 86, 229, 160] 5 bytes of data and couldn't parse it.
  5. 7.1

Ingest (HaishinKit x ffmpeg)

  1. 2.1
  2. 4.0
  3. 4.1
  4. 5.1
  5. 7.1

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots:

@shogo4405 shogo4405 added this to the 1.8.1 milestone Apr 30, 2024
@shogo4405 shogo4405 force-pushed the feature/aac-multi-channels branch 6 times, most recently from 451762b to 5c31388 Compare May 1, 2024 17:16
github-actions[bot]
github-actions bot reviewed May 1, 2024
View reviewed changes
Sources/Codec/AudioCodecSettings.swift
@@ -6,7 +6,7 @@ public struct AudioCodecSettings: Codable {
/// The default value.
public static let `default` = AudioCodecSettings()
/// Maximum number of channels supported by the system
public static let maximumNumberOfChannels: UInt32 = 2
static let maximumNumberOfChannels: UInt32 = 8
Copy link

@github-actions github-actions bot May 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The 'stat' is the require reason api. Please check privacy manifest files.

@shogo4405 shogo4405 force-pushed the feature/aac-multi-channels branch from 5c31388 to 2f518c5 Compare May 1, 2024 18:58
@shogo4405 shogo4405 marked this pull request as ready for review May 1, 2024 18:59
@shogo4405 shogo4405 changed the title [TBA] Supports AAC codec multi-channels. Supports AAC codec multi-channels. May 1, 2024
@shogo4405 shogo4405 merged commit 56417f0 into main May 1, 2024
2 checks passed
@shogo4405 shogo4405 deleted the feature/aac-multi-channels branch May 1, 2024 19:02
@shogo4405 shogo4405 mentioned this pull request May 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Milestone
1.8.1
Development

Successfully merging this pull request may close these issues.
1 participant
@shogo4405