-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using pickle and unpickle for loading and saving games #93
Comments
Update: seems like kpat already has an xml-based format for saved games which we can adopt instead of inventing our own new one. See https://en.wikipedia.org/wiki/Interoperability . |
I started preliminary work on this here - https://github.com/shlomif/PySolFC/tree/kpat-saved-games--issue93 . |
Just wanted to follow up on thread #426. I can now read in the old pso files, and study my solutions. Next on my wish list is to export the solutions to some format readable by another program. Currently you can export positions (to text files) but you cannot export sequences of moves. |
@math1414 : hi. I think I only started to write tests and production code for a predictable kpat-compatible xml emitter. My intention was to use it for freecell to start with, but I didn't get so far. |
Hi all!
See https://docs.python.org/3/library/pickle.html - it is insecure and makes it hard to share saved game files. We need a different format - perhaps https://metacpan.org/pod/File::Dir::Dumper::Stream::JSON::Reader or https://en.wikipedia.org/wiki/YAML .
The text was updated successfully, but these errors were encountered: