Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using pickle and unpickle for loading and saving games #93

Open
shlomif opened this issue Oct 8, 2018 · 4 comments
Open

Avoid using pickle and unpickle for loading and saving games #93

shlomif opened this issue Oct 8, 2018 · 4 comments

Comments

@shlomif
Copy link
Owner

shlomif commented Oct 8, 2018

Hi all!

See https://docs.python.org/3/library/pickle.html - it is insecure and makes it hard to share saved game files. We need a different format - perhaps https://metacpan.org/pod/File::Dir::Dumper::Stream::JSON::Reader or https://en.wikipedia.org/wiki/YAML .

@shlomif
Copy link
Owner Author

shlomif commented Apr 3, 2019

Update: seems like kpat already has an xml-based format for saved games which we can adopt instead of inventing our own new one. See https://en.wikipedia.org/wiki/Interoperability .

@shlomif
Copy link
Owner Author

shlomif commented May 11, 2019

I started preliminary work on this here - https://github.com/shlomif/PySolFC/tree/kpat-saved-games--issue93 .

@math1414
Copy link

Just wanted to follow up on thread #426. I can now read in the old pso files, and study my solutions. Next on my wish list is to export the solutions to some format readable by another program. Currently you can export positions (to text files) but you cannot export sequences of moves.
I'm curious, in your preliminary work on this, are you targeting Freecell specifically, or other games available on Pysol? It's an interesting question whether there are even notations for some of the others, such as Mahjongg.

@shlomif
Copy link
Owner Author

shlomif commented Jan 17, 2025

Just wanted to follow up on thread #426. I can now read in the old pso files, and study my solutions. Next on my wish list is to export the solutions to some format readable by another program. Currently you can export positions (to text files) but you cannot export sequences of moves. I'm curious, in your preliminary work on this, are you targeting Freecell specifically, or other games available on Pysol? It's an interesting question whether there are even notations for some of the others, such as Mahjongg.

@math1414 : hi. I think I only started to write tests and production code for a predictable kpat-compatible xml emitter. My intention was to use it for freecell to start with, but I didn't get so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants