Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redirect rules to be ordered via drag'n'drop #293

Closed
acelaya opened this issue Mar 17, 2024 · 0 comments · Fixed by #301
Closed

Allow redirect rules to be ordered via drag'n'drop #293

acelaya opened this issue Mar 17, 2024 · 0 comments · Fixed by #301
Labels
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Mar 17, 2024

Right now, the only way to order a rule is by clicking its up/down button, which can be cumbersome if you want to move it several places.

The buttons need to exist, for mobile devices and for accessibility reasons. However, that could coexist with a mechanism to drag rules in order to sort the list.

Additionally, there's a couple extra improvements that could be applied:

  • When clicking the up/down button of a rule, keep it focused so that it can be consecutively moved by pressing Enter/Space consecutive times.
  • When sorting via up/down buttons, reorder with an animation, otherwise the result is sometimes too subtle to know if it worked.
@acelaya acelaya added this to Shlink Mar 17, 2024
@acelaya acelaya moved this to In review in Shlink Mar 23, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Mar 23, 2024
@acelaya acelaya added this to the 0.6.1 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant