Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A GET manifest.json returns 401 error if page is protected by Basic Auth #316

Closed
jenkin opened this issue Oct 1, 2020 · 1 comment · Fixed by #318
Closed

A GET manifest.json returns 401 error if page is protected by Basic Auth #316

jenkin opened this issue Oct 1, 2020 · 1 comment · Fixed by #318
Labels
bug Something isn't working
Milestone

Comments

@jenkin
Copy link

jenkin commented Oct 1, 2020

Shlink web client version

  • Version: 2.6.0
  • How do you use shlink-web-client: self-hosted
  • Browser: Chromium version 83.0.4103.116 (Build) built on Debian 10.4, running on Debian 10.6 (64 bit)

Summary

If the web application is protected by Basic Authentication, all requests to manifest.json failed with a 401 error, also after authentication. But if you directly access /manifest.json, it works without issue.

Current behavior

Behind Basic Authentication, requests to manifest.json raise a 401 error.

Expected behavior

No errors, manifest is loaded without issues.

How to reproduce

Install shlink web client. Protect the directory using Basic Auth. Browse to the webpage, enter valid credentials, see the described error in console.

Hint for a solution

From this comment, add crossorigin="use-credentials" attribute to manifest link in index.html.

@jenkin jenkin added the bug Something isn't working label Oct 1, 2020
@acelaya acelaya added this to the 2.6.1 milestone Oct 3, 2020
@acelaya
Copy link
Member

acelaya commented Oct 3, 2020

Fixed! Thanks for the hint 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants