Fixed temperature sensors detection in Linux #905
Conversation
Previous implementation returns all values from the /sys/class/hwmon/hwmon*/temp* location. It was incorrect and very misleading. The SensorsTemperatures() should return only list of sensors. Current temperature values are only in the /sys/class/hwmon/hwmon*/temp*_input location. Reference: https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface Other files represent thresholds, alarms, setups. * Added new optional fields, High (*_max) and Critical (*_crit) * Removed redundant _input suffix. name + label is sufficient * Now temperatures, _ := host.SensorsTemperatures(); len(temperatures) returns exacts number of temperature sensors * Fixed label strings transformations. Replaced ' ' with '_'. Previous implementation transformed complex labels to unreadable and hard to parse strings
|
I'm experiencing this same issue on my Armbian based linux, as it contains the "temp*_label" but not the "temp*_input" required for this to work correctly.
Looking at the code changes in this PR, I believe they would fix my problem! |
|
This makes gopsutil more aligned with psutil and with more sensible results returned, which is always good. Though, it breaks backward compatibility for existing users, hence why I've been reluctant merging this. Also, this test should be fixed with the new fields. |
|
It seems Armbian fixed this from their side, as I now have the "temp*_input" after updating to the latest firmware:
Telegraf now correctly reports the temperature! |
|
I will merge this under v3 directory after v3 released (end of this month, perhaps). |
|
Merged by #938. Thank you for your contribution! |
Previous implementation returns all values from the /sys/class/hwmon/hwmon*/temp* location.
It was incorrect and very misleading. The SensorsTemperatures() should return only list of sensors.
Current temperature values are only in the /sys/class/hwmon/hwmon*/temp*_input location.
Reference: https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface
Other files represent thresholds, alarms, setups.
unreadable and hard to parse strings