Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Webpack 4 plugin loader. #17

Closed
Gisleburt opened this issue Mar 6, 2018 · 3 comments
Closed

Doesn't work with Webpack 4 plugin loader. #17

Gisleburt opened this issue Mar 6, 2018 · 3 comments

Comments

@Gisleburt
Copy link

Full details are here: jantimon/html-webpack-plugin#887

To summarise, Webpack 4 has changed the plugin loader, and so you get the following error:

  TypeError: callback is not a function
  
  - main.js:57 compilation.plugin
    [profile]/[webpack-cdn-plugin]/main.js:57:9
  
  
  - new Promise
  
  
  - Hook.js:35 AsyncSeriesWaterfallHook.lazyCompileHook [as _promise]
    [profile]/[tapable]/lib/Hook.js:35:21
  
  - index.js:647 
    [profile]/[html-webpack-plugin]/index.js:647:47
  
  - index.js:162 Promise.resolve.then.then.then.then.compilationResult
    [profile]/[html-webpack-plugin]/index.js:162:36
  
  
  - next_tick.js:160 process._tickCallback
    internal/process/next_tick.js:160:7

Relates to this module.js

Guide to upgrading

All credit for the useful information to @kagawagao

I don't have much time on my hands right now. If that changes, I'll try to do a pull request for you.

Currently everything works 💯 in Webpack 3 so want to add a thank you for such a neat tool. 😄

@raaymax
Copy link

raaymax commented Mar 8, 2018

👍

@shirotech
Copy link
Owner

Don’t worry guys, we have a PR in the works. Some migration issues not documented, so I’ll need to have a look this weekend.

@shirotech
Copy link
Owner

This has now been published as v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants