New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only an array ("sources") to define inputs for the build context #544

Open

adambkaplan opened this issue Jan 21, 2021 · 1 comment

Labels

kind/api-change

Member

adambkaplan commented Jan 21, 2021

In the Remote Artifacts EP [1], our accepted API contains two fields related to the input context (workspace) for builds:

"source", which is a git repository
"sources", which can be anything else

As a follow up, we should consolidate such that all inputs for the build context live in the "sources" array.

[1] https://github.com/shipwright-io/build/blob/master/docs/proposals/remote-artifacts.md#single-vs-multiple-git-repositories

Member

sbose78 commented Jan 25, 2021

Agreed, this would make our API a lot cleaner.

adambkaplan added the kind/api-change label

gabemontero mentioned this issue

WIP: Rebase BuildStrategy #656

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment