Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no version information in min.js #239

Closed
gtz42 opened this issue Jan 23, 2017 · 1 comment · Fixed by #305
Closed

no version information in min.js #239

gtz42 opened this issue Jan 23, 2017 · 1 comment · Fixed by #305

Comments

@gtz42
Copy link

gtz42 commented Jan 23, 2017

When tether is bundled in other projects, it's usually the minified/uglified version that is bundled.
Unfortunately this file does not contain any information about the version.
e.g. jQuery leaves this string:
/*! jQuery v2.2.2 | (c) jQuery Foundation | jquery.org/license */
Could you please keep such a string in tether, too?
Thanks.

Alternatively: is there a list of known tether.mini.js she-sums?

@yairEO
Copy link

yairEO commented Feb 2, 2017

I would suggest adding the license comment to the distributed JS files. Thanks :)

Also, there is a mis-match with this repo's license file and the MIT license mentioned at the bottom of the README file. it's it's in fact distributed under the MIT license then the license file should be in the format of an MIT license file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants