Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy stub files for admin.py #14

Closed
aitorres opened this issue Nov 15, 2021 · 2 comments · Fixed by #16
Closed

Add mypy stub files for admin.py #14

aitorres opened this issue Nov 15, 2021 · 2 comments · Fixed by #16

Comments

@aitorres
Copy link
Contributor

Hi everyone! I am trying to use this package on a project that has mypy type checking as part of the CI/CD, and I had to deactivate type-checks on my admin models that use the TabularInlinePaginated class since there are no type stub files.

I think a .pyi stub file for admin.py can be constructed upon the stubs for Django's admin/options.pyi.

If it seems like a good idea, I can work on it and submit a PR with the stub!
@shinneider
Copy link
Owner

@aitorres is a valid point!

You can work at PR, which I'll approve

@aitorres aitorres mentioned this issue Dec 18, 2021
Merged
3 tasks
@shinneider
Copy link
Owner

@aitorres i generated a new version 0.3.0 with your type hint and ISSUE-18 (your PR, removing ugetext).

update your requirements please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type hints to django_admin_inline_paginator module aitorres/django-admin-inline-paginator
2 participants
@aitorres @shinneider