Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.23.0 does not work with Bun #837

Closed
3 of 5 tasks
devunt opened this issue Nov 17, 2024 · 1 comment
Closed
3 of 5 tasks

v1.23.0 does not work with Bun #837

devunt opened this issue Nov 17, 2024 · 1 comment

Comments

@devunt
Copy link

devunt commented Nov 17, 2024

Validations

Describe the bug

Due to this issue in slevithan/oniguruma-to-es#2, shiki 1.23.0 does not work with latest Bun. Downgrading to 1.22.2 solves the issue.

I'm opening this issue on shiki's side too because this issue occurs even if I'm not using JavaScript RegExp Engine feature in shiki. Since this issue occurs because of static importing nature of the esm, make shiki imports @shikijs/engine-javascript dynamically on demand should solve this issue?

Reproduction

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@slevithan
Copy link
Collaborator

This is fixed by #836, released in Shiki 1.23.1.

@antfu antfu closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants