Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add code transformers support for the rose-pine theme #82

Closed
wants to merge 1 commit into from
Closed

fix: add code transformers support for the rose-pine theme #82

wants to merge 1 commit into from

Conversation

lzl0304
Copy link

@lzl0304 lzl0304 commented Aug 7, 2024

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for textmate-grammars-themes ready!

Name Link
🔨 Latest commit beed4f9
🔍 Latest deploy log https://app.netlify.com/sites/textmate-grammars-themes/deploys/66b3147865885c00079e566f
😎 Deploy Preview https://deploy-preview-82--textmate-grammars-themes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Aug 7, 2024

Thank you, but we couldn't just patch the themes, as they are synced with upstream and will get overridden. It's more like something on the shiki transformer side to support it.

@antfu antfu closed this Aug 7, 2024
@lzl0304
Copy link
Author

lzl0304 commented Aug 7, 2024

Thank you, but we couldn't just patch the themes, as they are synced with upstream and will get overridden. It's more like something on the shiki transformer side to support it.

I didn't notice that I needed to synchronize from upstream; I was thinking too simply.

@lzl0304 lzl0304 deleted the fix-rose-pine branch August 7, 2024 06:57
@davidwarrington
Copy link

@lzl0304 did you open a PR/issue for the Rose Pine VSCode theme at all? I've patched my current shikijs install with your fix (thank you so much btw), but keen to see this get resolved properly. Unfortunately I don't know enough about why your fix works to open this PR myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code transformers do not work correctly with rose-pine theme
3 participants