Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformerNotationDiff and transformerNotationHighlight don't apply any styles to code blocks #610

Closed
5 tasks done
francisko-rezende opened this issue Mar 3, 2024 · 4 comments

Comments

@francisko-rezende
Copy link
Contributor

Validations

Describe the bug

The transformers transformerNotationDiff and transformerNotationHighlight don't seem to be working. From what I've gathered, they do add their respective classes to the tags related to the code blocks but the classes don't seem to have any css rules, resulting in no visual changes to the lines that were supposed to be transformed.

image

Cheers and thanks for the awesome work you've been doing in this project :)

Reproduction

https://stackblitz.com/edit/vitejs-vite-rzz2qj?file=main.js

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@antfu
Copy link
Member

antfu commented Mar 3, 2024

It doesn't come with styles, it only transforms the markup and it's up to users to write the CSS themself.

@antfu antfu closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
@francisko-rezende
Copy link
Contributor Author

francisko-rezende commented Mar 3, 2024

Oh cool, thanks for the reply @antfu ! In that case may I suggest that that the docs make it a bit more explicit, specially in the section on Transformers? For instance, this bit makes me think that the styles are baked in
image

I'd gladly add a suggestion if that's alright :)

Cheers and thanks again

@antfu
Copy link
Member

antfu commented Mar 3, 2024

Of course! Would you like to send a quick PR to improve the docs? Thanks

@francisko-rezende
Copy link
Contributor Author

Sure thing, it'll be a pleasure! I'll get to it ASAP :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants