Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document commit integration in README directly #18

Closed
Jeehut opened this issue Apr 29, 2019 · 4 comments
Closed

Document commit integration in README directly #18

Jeehut opened this issue Apr 29, 2019 · 4 comments

Comments

@Jeehut
Copy link

Jeehut commented Apr 29, 2019

I just wanted to test this out, but after reading the README I wasn't sure at first how commit hooks would get setup in my project since the swift run komondor install method was only documented within the "Getting Set Up" documents, but I personally think it's the key command and should be explained right within the README.

@orta
Copy link
Member

orta commented Apr 29, 2019

Sure, happy to accept a PR 👍

@Jeehut
Copy link
Author

Jeehut commented Apr 29, 2019

I would happily post a PR, but first to understand it correctly: In the SwiftPM "Getting Set Up" there is no mentions of the swift run komondor install command, is it even needed in that case?

@orta
Copy link
Member

orta commented Apr 29, 2019

Yep, should be - likely is an oversight

@Jeehut
Copy link
Author

Jeehut commented Apr 30, 2019

Ah, no, the swift run komondor install command is already mentioned in the README. So this might not have been an issue in the end. Must have overseen it. Closing.

@Jeehut Jeehut closed this as completed Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants