Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove startup filter and hosted service #10

Merged
merged 1 commit into from
May 5, 2023
Merged

fix: remove startup filter and hosted service #10

merged 1 commit into from
May 5, 2023

Conversation

delepster
Copy link
Member

@delepster delepster commented May 3, 2023 •
edited
Loading

BREAKING CHANGE: configuration methods are removed

Summary of changes1

Remove startup filter and hosted service. The integration will be done through the OfficeProtect.Application classes.

Related Work Item: AB#44971

Dependencies

https://github.com/sherweb/OfficeProtect.Application/pull/238

Dependents2

https://github.com/sherweb/OfficeProtect.Application/pull/238

Checks

  • I have labeled the PR correctly
  • I have set the PR title with the proper versioning3 prefix (will help for the merge commit message)
  • I have added tests that prove my fix is effective or that my feature works
  • I have maximized the division of this story and could not make multiple smaller PRs
  • I have used stable versions for every package in this PR (if not dependending on an unclosed PR)
  • The changelog is written in the story

image

Footnotes

  1. https://wiki.sherweb.com/display/TUR/Meilleures+pratiques+pour+la+revue+de+pull+requests ↩

  2. https://github.com/sherweb/OfficeProtect.Utils/blob/master/dependencies/README.md ↩

  3. https://github.com/sherweb/OfficeProtect.Application/blob/master/docs/software/application-versioning.md ↩

@delepster
fix: remove startup filter and hosted service
f77c960 
BREAKING CHANGE: configuration methods are removed
@delepster delepster added breaking change Introducing changes that will break the consumer code refactoring No functional changes, no api changes labels May 3, 2023
@delepster delepster marked this pull request as ready for review May 5, 2023 12:18
@delepster delepster requested a review from a team as a code owner May 5, 2023 12:18
@delepster delepster requested review from VSt-Louis, ogagnon96, Delp1904 and lmgendron and removed request for a team, VSt-Louis and ogagnon96 May 5, 2023 12:18
@delepster delepster merged commit fc1e221 into master May 5, 2023
@delepster delepster deleted the startup branch May 5, 2023 18:17
@op-github-svc
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmgendron lmgendron lmgendron approved these changes

@Delp1904 Delp1904 Delp1904 approved these changes

Assignees
No one assigned
Labels
breaking change Introducing changes that will break the consumer code refactoring No functional changes, no api changes released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delepster @op-github-svc @Delp1904 @lmgendron