Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove torrequest dependency #2211

Open
1 task done
ppfeister opened this issue Jun 30, 2024 · 2 comments · May be fixed by #2200
Open
1 task done

Remove torrequest dependency #2211

ppfeister opened this issue Jun 30, 2024 · 2 comments · May be fixed by #2200
Assignees
@sdushantha
Labels
enhancement New feature or request

Comments

@ppfeister
Copy link
Member

Description

Dependency torrequest is 6 years unmaintained and will be deprecated in a future version of Sherlock.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ppfeister ppfeister added the enhancement New feature or request label Jun 30, 2024
@ppfeister ppfeister linked a pull request Jun 30, 2024 that will close this issue
removed support for tor #2200
Open
@ppfeister ppfeister moved this to Done in Release 0.16.0 Jun 30, 2024
@ppfeister ppfeister closed this as completed by moving to Done in Release 0.16.0 Jun 30, 2024
@ppfeister ppfeister moved this from Done to Approved in Release 0.16.0 Jun 30, 2024
@ppfeister ppfeister reopened this Jun 30, 2024
@ppfeister ppfeister changed the title Deprecate torrequest Remove torrequest dependency Jul 8, 2024
@sdushantha
Copy link
Member

I believe this can be closed, can you confirm @ppfeister?

@ppfeister
Copy link
Member Author

Since torrequest wasn't actually removed, only made optional for #2130, this should remain open and on the backlog for 0.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdushantha sdushantha

Labels
enhancement New feature or request
Projects
Release 0.16.0
Status: Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed support for tor sherlock-project/sherlock
2 participants
@sdushantha @ppfeister