NoOne - Missing check for zero amount

[sherlock-admin2]

NoOne

Medium

Missing check for zero amount

Summary

In the documentation, it is mentioned that Any type of ERC20 token. Pools are permissionless. So users can open pools even with weird tokens. Some tokens (e.g. LEND) revert when transferring a zero value amount. example: RevertZero.sol. This introduces a risk related to revert on 0 amount

Vulnerability Detail

Impact

Revert on Zero Amount: When balance is zero, the safeTransfer and safeTransferFrom method from most ERC20 token contracts will revert. This behavior is intended to prevent unintentional transfers of zero tokens, which could be seen as an error in many token implementations.

Code Snippet

emergencyWithdraw

emergencyWithdraw

fundAndBribe

Tool used

Manual Review

Recommendation

To handle revert on zero amount , modify the functions to check the actual amount before safeTransfer and safeTransferFrom

Duplicate of #545