Honour - DOS on voting for pools with bribeRewarder due to incorrect check on _modify

[sherlock-admin3]

Honour

High

DOS on voting for pools with bribeRewarder due to incorrect check on _modify

Summary

Voting for pools with a bribeRewarder reverts due to incorrect logic in _modify

Vulnerability Detail

During voting ,the voter contract calls the deposit function on the respective bribeRewarder which in turn calls the _modify function. However the _modify function reverts if the msg.sender is not the token owner, which means that its not possible to vote for pools with a bribeRewarder

Impact

Voting for pools with a bribeRewarder reverts

Code Snippet

https://github.com/sherlock-audit/2024-06-magicsea/blob/main/magicsea-staking/src/Voter.sol#L221-L229

https://github.com/sherlock-audit/2024-06-magicsea/blob/main/magicsea-staking/src/rewarders/BribeRewarder.sol#L143-L147

https://github.com/sherlock-audit/2024-06-magicsea/blob/main/magicsea-staking/src/rewarders/BribeRewarder.sol#L264-L266

Tool used

Manual Review

Recommendation

 function _modify(uint256 periodId, uint256 tokenId, int256 deltaAmount, bool isPayOutReward)
        private
        returns (uint256 rewardAmount)
    {
-       if (!IVoter(_caller).ownerOf(tokenId, msg.sender)) {
-           revert BribeRewarder__NotOwner();
-       }

+       if (msg.sender != _caller &&  !IVoter(_caller).ownerOf(tokenId, msg.sender) ) {
+           revert BribeRewarder__NotOwner();
+       }
    }

Duplicate of #39