Honour - Briber has no way to claim unclaimed bribes after bribing period ends as stated by the docs

[sherlock-admin2]

Honour

Medium

Briber has no way to claim unclaimed bribes after bribing period ends as stated by the docs

Summary

Briber has no way to claim unclaimed bribes after bribing period ends

Vulnerability Detail

It's stated in the docs

the briber can re-claim unclaimed bribes after the bribing period ends , But the BribeRewarder does not have a function for this

Impact

Broken functionality

Code Snippet

https://github.com/sherlock-audit/2024-06-magicsea/blob/main/magicsea-staking/src/rewarders/BribeRewarder.sol#L1

Tool used

Manual Review

Recommendation

function sweep() external onlyOwner {
    require(IVoter(_caller).getCurrentVotingPeriod() > _lastVotingPeriod + 1 );
    _safeTransferTo(_token(), msg.sender , balanceOfThis(_token()));
}

Duplicate of #172

[WangSecurity]

Now a duplicate of #172, based on #164 (comment) and #164 (comment) comments.