snapishere - "remaining lock period needs to be longer then the epoch time" this condition stated in the docs is not met within the vote function

[sherlock-admin3]

snapishere

Medium

"remaining lock period needs to be longer then the epoch time" this condition stated in the docs is not met within the vote function

Summary

"remaining lock period needs to be longer then the epoch time" condition is not met/implemented wrong.

Vulnerability Detail

Condition not met/implemented wrong.

Impact

Allowing someone to vote for a low liquidity token with above 50 LUM then then during voting epoch when they can withdraw add liquidity to the token and getting shares to profit of the emissions. Also allows someone to double vote during the period claiming more rewards than they should get with the same eth staked.

Code Snippet

https://github.com/sherlock-audit/2024-06-magicsea/blob/main/magicsea-staking/src/Voter.sol#L175

Tool used

Manual Review

Recommendation

solidity if (_mlumStaking._remainingLockTime(position) < _periodDuration) {

Duplicate of #166