This repository has been archived by the owner on May 26, 2023. It is now read-only.
hake - Incorrect function spec or functionality #59
Labels
Duplicate
A valid issue that is a duplicate of an issue with `Has Duplicates` label
Non-Reward
This issue will not receive a payout
Comments
github-actions
bot
added
Duplicate
sherlock-admin
added
Non-Reward
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
hake
false
Incorrect function spec or functionality
Summary
solvent()function claims to determine "whether or not an ongoing bounty or tiered bounty have enough funds to cover payouts". However it only works for ongoing bounties and not tiered bounties.Vulnerability Detail
The ongoing bounties are the only type of bounty containing the variable
payoutVolumehttps://github.com/sherlock-audit/2023-02-openq/blob/main/contracts/Bounty/Storage/OngoingBountyStorage.sol#L16-L17
Impact
Not possible to call
solvent()on tiered bounties.Code Snippet
https://github.com/sherlock-audit/2023-02-openq/blob/main/contracts/OpenQ/Implementations/OpenQV1.sol#L406-L414
Tool used
Manual Review
Recommendation
Correct specification or implement
payoutVolumein tiered bounties.Duplicate of #301
The text was updated successfully, but these errors were encountered: