Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Jeiwan - The NFT deposit limit may be not enough for tiered bounties #533

Closed
github-actions bot opened this issue Feb 22, 2023 · 0 comments
Closed
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

Jeiwan

medium

The NFT deposit limit may be not enough for tiered bounties

Summary

The number of tiers is not limited in the tiered bounty contracts, however no more than 5 NFT tokens can be deposited to a bounty contract. As a result, bounty minters cannot run bounty programs that have more than 5 tiers and that award winners with NFTs.

Vulnerability Detail

When initializing a tiered bounty contract, the maximal number of NFT tokens tha can be funded is set to 5, without allowing the minter to change the number. A tiered bounty contract cannot receive more than the 5 NFT tokens. However, the number of tiers in a bounty program is not limited.

Impact

Bounty minters cannot use the protocol to run bounty programs with more than 5 tiers that award winners with NFT tokens.

Code Snippet

TieredPercentageBountyV1.sol#L48
TieredFixedBountyV1.sol#L49
TieredBountyCore.sol#L25-L28

Tool used

Manual Review

Recommendation

In the tiered bounty contracts, consider letting bounty minters decide the deposit limit of NFT tokens.

Duplicate of #262

@github-actions github-actions bot added Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue labels Feb 22, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant