Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

kiki_dev - Ongoing Bounty accepts nfts however there is no option to claim an nft, missing functionality #342

Closed
github-actions bot opened this issue Feb 21, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Non-Reward This issue will not receive a payout

Comments

@github-actions
Copy link

github-actions bot commented Feb 21, 2023

kiki_dev

medium

Ongoing Bounty accepts nfts however there is no option to claim an nft, missing functionality

Summary

Currently Ongoing Bounties have access to the functions inside of bountyCore rightfully so. However not all functions in bounty core should be applicable to onGoing bounty. In particular funding an NFT. There is no way for a user to claim an NFT from an ongoingbounty. Unlike other bounty tyoes the only option is to claim a token.

this leads to users needlessly locking up thier NFT for extended periods of time with no actual use. At worst this could be a form of false advertising. where a issuer deposits a valuable NFT to attract work knowing that it is not possible for the claimant to actually get the NFT.

Vulnerability Detail

See Summary

Impact

Temporary locked up NFT
Oppourtunity to falsy advertise a bounty.

Code Snippet

https://github.com/sherlock-audit/2023-02-openq/blob/main/contracts/Bounty/Implementations/OngoingBountyV1.sol#L96

Tool used

Manual Review

Recommendation

There should either be a way for a user to claim an NFT from onGoingBounty. Or there needs to be a check that prevents a user from depositing NFTs to onGoing bounties.

Duplicate of #261

@github-actions github-actions bot added Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue labels Feb 21, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Mar 7, 2023
@sherlock-admin sherlock-admin added Non-Reward This issue will not receive a payout and removed Medium A valid Medium severity issue Reward A payout will be made for this issue labels Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Non-Reward This issue will not receive a payout
Projects
None yet
Development

No branches or pull requests

1 participant