This repository has been archived by the owner on May 26, 2023. It is now read-only.
shw - Incorrect code comments in the StandardBridge.sol contract
#264
Labels
Has Duplicates
A valid issue with 1+ other issues describing the same vulnerability
Reward
A payout will be made for this issue
Specification
An issue related to the specification (low severity)
Comments
github-actions
bot
added
Has Duplicates
This was referenced Feb 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
shw
low
Incorrect code comments in the
StandardBridge.solcontractSummary
Incorrect code comments in the
StandardBridge.solcontract.Vulnerability Detail
The code comments for the
bridgeERC20andbridgeERC20Tofunctions in theuniversal/StandardBridge.solcontract do not match the actual code. The comments say the bridge returns tokens to the sender if the bridging fails, but the refund logic has been removed since PR#3535.Impact
Specfication error only.
Code Snippet
https://github.com/ethereum-optimism/optimism/blob/3f4b3c328153a8aa03611158b6984d624b17c1d9/packages/contracts-bedrock/contracts/universal/StandardBridge.sol#L219-L222
https://github.com/ethereum-optimism/optimism/blob/3f4b3c328153a8aa03611158b6984d624b17c1d9/packages/contracts-bedrock/contracts/universal/StandardBridge.sol#L251-L254
Tool used
Manual Review
Recommendation
Remove the outdated code comments.
The text was updated successfully, but these errors were encountered: