This repository has been archived by the owner on May 26, 2023. It is now read-only.
ustas - Misleading gap size #1
Labels
Duplicate
A valid issue that is a duplicate of an issue with `Has Duplicates` label
Reward
A payout will be made for this issue
Specification
An issue related to the specification (low severity)
ustas
low
Misleading gap size
Summary
The gap size in the comments and the actual code are different; the size is incorrect in both variants.
Vulnerability Detail
According to the documentation, the gap's size should equal 44 because there are 6 used storage slots in the contract.
Impact
This is misleading and could impact future upgrades.
Code Snippet
https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/universal/CrossDomainMessenger.sol#L132-L137
https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/.storage-layout#L9-L45
Tool used
Manual Review, VSCodium
Recommendation
Change the size to 44.
Duplicate of #146
The text was updated successfully, but these errors were encountered: