Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus trap, to disallow tabbing outside the modal #408

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Add focus trap, to disallow tabbing outside the modal #408

merged 3 commits into from
Jun 21, 2019

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Jun 21, 2019 •
edited
Loading

This keyboard trap implementation was taken from https://bitsofco.de/accessible-modal-dialog/ and is related to #198

@RobbieTheWagner
Copy link
Member Author

@chuckcarpenter do you think we should trap the keyboard for both modal and non-modal or only modal?

chuckcarpenter
chuckcarpenter approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't considered this, but makes sense to me.

@RobbieTheWagner RobbieTheWagner merged commit cbbdf2a into master Jun 21, 2019
@RobbieTheWagner RobbieTheWagner deleted the trap-focus branch June 21, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckcarpenter chuckcarpenter chuckcarpenter approved these changes

Assignees
No one assigned
Labels
a11y enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbieTheWagner @chuckcarpenter