Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue: role do not have all required aria attributes #1780

Closed
antsteyeragorize opened this issue Jun 20, 2024 · 2 comments
Closed

Comments

@antsteyeragorize
Copy link

Reproduction Link

https://vue-multiselect.js.org/#sub-getting-started

Not working on actual 3.x version
and since 2.1.7.

Was working on 2.1.6 version.

Steps to reproduce

  • Open chrome console
  • go to "Lighthouse" tab
  • Analyse page load with mode "Navigation", device "Desktop" and category "Accessibility"

Expected behaviour

Should not have accessibility issues

Actual behaviour

Capture d’écran 2024-06-20 à 16 25 20

I'm using vue-multiselect 2.1.x on my project, can you please make the fix also for 2.x versions ? Thanks !

@antsteyeragorize antsteyeragorize changed the title Accessibility issue with role combobox Accessibility issue with role combobox: role do not have all required aria attributes Jun 20, 2024
@antsteyeragorize antsteyeragorize changed the title Accessibility issue with role combobox: role do not have all required aria attributes Accessibility issue: role do not have all required aria attributes Jun 20, 2024
@rustamidastan
Copy link

rustamidastan commented Sep 12, 2024

Hi, I have solved this problem by adding these properties to component where I am using.
aria-label="language select" aria-autocomplete="list" aria-expanded="false" aria-controls="popup_listbox"

@mattelen
Copy link
Collaborator

mattelen commented Feb 7, 2025

Since the latest release we have added and updated aria values. This has resulted with no issues in Lighthouse around missing roles.

Unfortunately we don't have the resources to support older versions of the multiselect, especially since Vue 2 has reached end of life. You could try the above suggestion and see how you get on

@mattelen mattelen closed this as completed Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants