-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch this to use shelljs as a git submodule (for now) #13
Comments
What is the advantage to the submodule vs an npm dep here? |
@levithomason the advantage (for right now) is that the submodule can be more up-to-date than the npm dep. The master branch has progressed quite a bit from v0.6. Since we're trying to get this project released as soon as v0.7 comes out, we'll have a smoother transition if we develop against shelljs master branch, vs. against shelljs v0.6. This is only a temporary change, since once v0.7 is actually released, we'll want to switch to that instead of doing the git submodule. The alternative is that we keep it as-is and just do a little bit more work once v0.7 comes out. Not the worst thing in the world. |
What about What say ye? |
I think we should do that, because ideally once 0.7 is released we'll want to keep testing master. Plus, may as well keep everything as npm. |
Ah, didn't know about that option. That sounds good to me. We should switch to v0.7 once it gets released though, for stability's sake. |
Absolutely, we def don't want to ship anything with a direct github install. Especially without a commit sha ref. I'll get a PR for this. |
Since we're planning to release this with v0.7, it makes more sense to have shelljs included as a submodule (since master is most of the way to v0.7).
Once v0.7 lands, we can swap out the submodule for a regular npm dependency. If all the tests pass, we can release it.
The text was updated successfully, but these errors were encountered: