Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch this to use shelljs as a git submodule (for now) #13

Closed
nfischer opened this issue Mar 13, 2016 · 6 comments
Closed

Switch this to use shelljs as a git submodule (for now) #13

nfischer opened this issue Mar 13, 2016 · 6 comments

Comments

@nfischer
Copy link
Member

Since we're planning to release this with v0.7, it makes more sense to have shelljs included as a submodule (since master is most of the way to v0.7).

Once v0.7 lands, we can swap out the submodule for a regular npm dependency. If all the tests pass, we can release it.

@levithomason
Copy link
Contributor

What is the advantage to the submodule vs an npm dep here?

@nfischer
Copy link
Member Author

@levithomason the advantage (for right now) is that the submodule can be more up-to-date than the npm dep. The master branch has progressed quite a bit from v0.6. Since we're trying to get this project released as soon as v0.7 comes out, we'll have a smoother transition if we develop against shelljs master branch, vs. against shelljs v0.6.

This is only a temporary change, since once v0.7 is actually released, we'll want to switch to that instead of doing the git submodule.

The alternative is that we keep it as-is and just do a little bit more work once v0.7 comes out. Not the worst thing in the world.

@levithomason
Copy link
Contributor

What about npm i shelljs/shelljs -S, installing the dep from the latest master? Any update to master on shelljs can be instantly installed. In my experience, submodules are more of a pain to manage. If we are consider this for a short term, I'd like to suggest considering the install from github approach.

What say ye?

@ariporad
Copy link
Contributor

I think we should do that, because ideally once 0.7 is released we'll want to keep testing master. Plus, may as well keep everything as npm.

@nfischer
Copy link
Member Author

Ah, didn't know about that option. That sounds good to me. We should switch to v0.7 once it gets released though, for stability's sake.

@levithomason
Copy link
Contributor

Absolutely, we def don't want to ship anything with a direct github install. Especially without a commit sha ref. I'll get a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants