Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: card-group perf #764

Merged
merged 1 commit into from
Oct 29, 2024
Merged

perf: card-group perf #764

merged 1 commit into from
Oct 29, 2024

Conversation

saint3347
Copy link
Collaborator

@saint3347 saint3347 commented Oct 29, 2024

Types of changes

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Others

Background

Information Descriptions
Browser Chrome / Safari /
Version Chrome 49 ...
OS MacOS / Windows ...

Changelog

Other information

Summary by CodeRabbit

  • 新功能

    • 更新了组件以支持新的可选属性 lazyLoadOffset,增强了懒加载的灵活性。
  • 性能改进

    • 组件生命周期管理进行了优化,使用 useLayoutEffect 替代 useEffect,提升了性能和响应性。
  • 版本更新

    • 版本号从 3.4.5-beta.3 更新至 3.4.5-beta.4

Copy link

coderabbitai bot commented Oct 29, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

本次更改包括对 package.json 文件版本号的更新,从 "3.4.5-beta.3" 更改为 "3.4.5-beta.4"。此外,packages/base/src/card-group/item.tsx 文件中的 Item 组件进行了多项修改,包括将 useEffect 替换为 useLayoutEffect,扩展 useInView 钩子的返回值以包含 wasInView,并更新 rootMargin 参数以使用可选的 props.lazyLoadOffset。最后,packages/base/src/card-group/item.type.ts 文件中新增了可选属性 lazyLoadOffset,用于指定懒加载的偏移量。

Changes

文件路径 更改摘要
package.json 版本号更新:"3.4.5-beta.3""3.4.5-beta.4"
packages/base/src/card-group/item.tsx - 将 useEffect 替换为 useLayoutEffect
- 扩展 useInView 返回值,增加 wasInView
- 更新 rootMargin 使用 props.lazyLoadOffset
- 使用 offsetHeight 设置 itemHeight
- 修改 hiddenStyle 逻辑
- 合并 hiddenStyleprops.style
packages/base/src/card-group/item.type.ts 新增可选属性 lazyLoadOffset?: numberCardGroupItemProps 接口

Possibly related PRs

在兔子洞里跳跃,
新版本如春风吹,
懒加载更灵活,
组件更聪明飞。
代码如花绽放,
兔子乐无穷。 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@saint3347 saint3347 merged commit 610410e into main Oct 29, 2024
1 check failed
@coderabbitai coderabbitai bot mentioned this pull request Oct 30, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant