New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests pass for enviroments even with broken imports #17

Open

shashikumarraja opened this issue May 25, 2020 · 0 comments

Assignees

Labels

bug good first issue

Owner

shashikumarraja commented May 25, 2020 •

edited

Loading

Describe the bug
Using line
from utils import FileUtils

in naughty_string_validator.py breaks the code in python version 3 but tests keep on passing in tox environment py35, py36. py37,py38

venv3/lib/python3.7/site-packages/naughty_string_validator/naughty_string_validator.py", line 3, in <module>
    from utils import FileUtils
ModuleNotFoundError: No module named 'utils'

Expected behavior
Tests should fail for tox environment py35, py36. py37,py38

Need to investigate and modify tests so that it catches such import failure erros in specific tox environments

The text was updated successfully, but these errors were encountered:

shashikumarraja self-assigned this

shashikumarraja added bug good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment