Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lucashpandolfo
Copy link

Two tests were failing due to stopwords functionality.

I am not sure about add-indexes method. I jut don't know. (elt indexes 0) was failing because indexes was a vector instead of a list, but i'm pretty sure elt should work for vectors too. 😱
¿Ideas?

@PuercoPop
Copy link
Contributor

@lucashpandolfo: Scymtym points the reason why SBCL chokes on add-indexes is because SBCL assumes indexes (as a &rest parameter) is bound to a list. This can be fixed with a (declare (cl:optimize (safety 3))), but it would be better to rewrite the funciton

<scymtym> PuercoPop: the (montezuma:add-indexes index) method assigns
                a vector value to the &rest parameter. SBCL seems to assume
                that the variable will only be bound to list values
09:29 *** porky11 QUIT Remote host closed the connection
09:30 *** mrcom QUIT Quit: This computer has gone to sleep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants