can not download files automatic

[toohandsome]

1.when i click a link to download a file. it will open a new tab,and do nothing.
2.when i click downloads , it will crash

[sgbhavsar]

It seems that there is breaking change in cefsharp to register asynchjsobject which requires to be updated.

[dpbiz]

There are some changes to make:

Remove the following from app.config (remove entire lines:

<add key="torConfigurationFile" value=""/>
<add key="torControlPassword" value=""/>
<add key="torControlPort" value="9051"/>
<add key="torDefaultConfigurationFile" value=""/>
<add key="torPath" value="Tor\Tor\tor.exe"/>

================

Update the following files:

1. SharpBrowser.csproj, see (Feature Request - Add AnyCPU Support cefsharp/CefSharp#1714)
   a. add <CefSharpAnyCpuSupport>true</CefSharpAnyCpuSupport> to the first <PropertyGroup>
2. MainForm.cs (see Javascript Binding v2 cefsharp/CefSharp#2246)
   a. after line 391, add the following before if (url.StartsWith("sharpbrowser:")) {:

//For legacy biding we'll still have support for this CefSharpSettings.LegacyJavascriptBindingEnabled = true;

3. MainForm.cs - Change method on line 824 from:

public string CalcDownloadPath(DownloadItem item) {

string itemName = item.SuggestedFileName != null ? item.SuggestedFileName.GetAfterLast(".") + " file" : "downloads";

			string path = null;
			if (path != null) {
				return path;
			}

			return null;
		}

to

public string CalcDownloadPath(DownloadItem item) { return item.SuggestedFileName; }

4. DownloadHandler.cs replace the entire file with the following code:

using CefSharp;

namespace SharpBrowser {
	internal class DownloadHandler : IDownloadHandler {
		readonly MainForm myForm;

		public DownloadHandler(MainForm form) {
			myForm = form;
		}

		public void OnBeforeDownload(IWebBrowser chromiumWebBrowser, IBrowser browser, DownloadItem downloadItem, IBeforeDownloadCallback callback) {
			if (!callback.IsDisposed) {
				using (callback) {

					myForm.UpdateDownloadItem(downloadItem);

					// ask browser what path it wants to save the file into
					string path = myForm.CalcDownloadPath(downloadItem);

					// if file should not be saved, path will be null, so skip file
					if (path == null) {

						// skip file
						callback.Continue(path, false);

					} else {

						// open the downloads tab
						myForm.OpenDownloadsTab();
						callback.Continue(path, true);
					}

				}
			}
		}

		public void OnDownloadUpdated(IWebBrowser chromiumWebBrowser, IBrowser browser, DownloadItem downloadItem, IDownloadItemCallback callback) {
			myForm.UpdateDownloadItem(downloadItem);
			if (downloadItem.IsInProgress && myForm.CancelRequests.Contains(downloadItem.Id)) {
				callback.Cancel();
			}
		}
	}
}

5. HostHandler.cs, replace line 13 from:

MainForm myForm;

to

readonly MainForm myForm;

[robinrodricks]

@dpbiz all fixes implemented, thanks.