Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"BIN file was corrupted, please download it again" should smartly resume and perhaps not reload entire game #630

Open
ell1e opened this issue Dec 14, 2024 · 0 comments

Comments

@ell1e
Copy link

ell1e commented Dec 14, 2024

Thanks to the awesome #615 fix ❤️ I got to try to download a few multi part games again, but I ran into another curious corner case: I got a "BIN file was corrupted, please download it again" error for Fallout 3 GOTY. This seems a bit strange since even with an extremely shaky connection, TLS should usually ensure integrity. But assuming that this really was caused by a connection hiccup anyway, rather than some bug in the downloader, e.g. the downloader not transparently doing a HTTPS resume when the download fell short, there seem to be two things that are a bit odd about what happens after:

  1. The message appearing in the first place. Usually, for a smart downloader e.g. like Steam, the established behavior would be to simply quietly resume redownloading the affected part. The user interaction doesn't really seem to be required here.

  2. The way the recovery is done when redownloading. When I prompt it to restart, minigalaxy seems to then proceed to start over the entire game from scratch, rather than just the affected BIN file, at least from how the progress bar looks like. Especially for bigger games, which are now not uncommon on GOG, this seems like it doesn't really scale well if that's how errors are handled.

Affected minigalaxy version: 1.3.1 (via Flathub)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant