Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dark mode #229

Merged
merged 5 commits into from
Sep 7, 2020
Merged

Implement dark mode #229

merged 5 commits into from
Sep 7, 2020

Conversation

septatrix
Copy link
Contributor

@septatrix septatrix commented Jun 14, 2020

This is a simple draft of a dark mode and fixes #227.

A few things which still might need improvement:

  • I just made the logo white which may not be the desired solution and an alternative would be a filter: drop-shadow(0 0 1px white)
  • The terminal could also be styled to fit the theme a bit better as the contrast is currently a bit low. However only the compiled styles are included and I did not bother with looking for the specific classes
  • Currently two octicon badges are included however we may be able to implement this with just styling the svg as it is inline

@septatrix septatrix changed the title Implement dark mode (fixes #227) Implement dark mode Jun 14, 2020
@sharkdp
Copy link
Owner

sharkdp commented Jul 26, 2020

Thank you very much for working on this. This looks great, so far. I would appreciate if we could find a way to make the logo look better. Maybe a monochrome version with some colors inverted?

@septatrix
Copy link
Contributor Author

You can preview a monochrome version using

document.getElementById('insect-logo').querySelector('defs').remove()

a version with a white shadow using

document.getElementById('insect-logo').style.color = 'black'
document.getElementById('insect-logo').style.filter = 'drop-shadow(0 0 3px #ECF0F1)'

and a hybrid version using

document.getElementById('insect-logo').querySelector('defs').remove()
document.getElementById('insect-logo').style.color = 'black'
document.getElementById('insect-logo').style.filter = 'drop-shadow(0 0 10px #ECF0F1)'

and simply pasting those into the console and maybe play around with the pixel value for the drop-shadow.
These obviously would need to be set in the html/css source if one of these variants suits you

@sharkdp
Copy link
Owner

sharkdp commented Aug 1, 2020

I was thinking about actually modifying the original logo in Inkscape (or similar) to create a dark theme version.

But I actually quite like the CSS-modified hybrid version. What do you think?

Thank you for the different variants!

@septatrix
Copy link
Contributor Author

I have no strong opinion about this. Creating a new logo would certainly also work (even css only using <picture> with a srcset and media attribute). However whilst not as colorful I think the css modifications still preserve the original style.

@sharkdp
Copy link
Owner

sharkdp commented Sep 1, 2020

Ok, let's go with the "hybrid version" for now 👍

@septatrix
Copy link
Contributor Author

Done :D

@sharkdp
Copy link
Owner

sharkdp commented Sep 7, 2020

Awesome, thank you very much for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark style / dark scrollbar for web UI
2 participants