Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint to CircleCI #320

Closed
2 tasks done
elmutt opened this issue Mar 14, 2022 · 5 comments · Fixed by #324
Closed
2 tasks done

Add golangci-lint to CircleCI #320

elmutt opened this issue Mar 14, 2022 · 5 comments · Fixed by #324
Labels
bounty Issue is posted on dework.xyz as a bounty

Comments

@elmutt
Copy link
Collaborator

elmutt commented Mar 14, 2022

Overview

We need standard linting checks for unchained in CircleCI. Use golangci-lint to lint pull requests in CircleCI

Reference

https://github.com/golangci/golangci-lint
https://github.com/shapeshift/unchained/blob/develop/.circleci/config.yml

Acceptance Criteria

  • Use golangci-lint V1.44.2

  • Enable lint step in unchained-precheck-go job

  • Fix any existing lint errors throughout the go project

  • PR's are linted during CI using golangci-lint and rejected if anything is wrong

Need By Date

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@elmutt elmutt added needs bounty To be posted on Gitcoin and removed needs bounty To be posted on Gitcoin labels Mar 14, 2022
@0xean 0xean added bounty Issue is posted on dework.xyz as a bounty and removed needs bounty To be posted on Gitcoin labels Mar 14, 2022
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1100.0 FOX (294.68 USD @ $0.27/FOX) attached to it as part of the ShapeShift fund.

@gitcoinbot
Copy link

gitcoinbot commented Mar 14, 2022

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 8 months from now.
Please review their action plans below:

1) trungtin has been approved to start work.

I have set up this in one of my projects, can do the same on unchained repo swiftly.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1100.0 FOX (294.68 USD @ $0.27/FOX) has been submitted by:

  1. @trungtin

@0xean please take a look at the submitted work:


@0xean
Copy link
Contributor

0xean commented Mar 15, 2022

payment is on its way! Thanks for another one @trungtin

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 1100.0 FOX (297.76 USD @ $0.27/FOX) attached to this issue has been approved & issued to @trungtin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Issue is posted on dework.xyz as a bounty
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants