-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golangci-lint to CircleCI #320
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 1100.0 FOX (294.68 USD @ $0.27/FOX) attached to it as part of the ShapeShift fund.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 264 years, 8 months from now. 1) trungtin has been approved to start work. I have set up this in one of my projects, can do the same on unchained repo swiftly. Learn more on the Gitcoin Issue Details page. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 1100.0 FOX (294.68 USD @ $0.27/FOX) has been submitted by: @0xean please take a look at the submitted work:
|
payment is on its way! Thanks for another one @trungtin |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 1100.0 FOX (297.76 USD @ $0.27/FOX) attached to this issue has been approved & issued to @trungtin.
|
Overview
We need standard linting checks for unchained in CircleCI. Use golangci-lint to lint pull requests in CircleCI
Reference
https://github.com/golangci/golangci-lint
https://github.com/shapeshift/unchained/blob/develop/.circleci/config.yml
Acceptance Criteria
Use golangci-lint V1.44.2
Enable lint step in unchained-precheck-go job
Fix any existing lint errors throughout the go project
PR's are linted during CI using golangci-lint and rejected if anything is wrong
Need By Date
No response
Ownership
Bounty Hunters
The text was updated successfully, but these errors were encountered: