Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate new cosmos/osmosis zero-fee reference TXes #525

Open
mrnerdhair opened this issue Apr 26, 2022 · 0 comments
Open

generate new cosmos/osmosis zero-fee reference TXes #525

mrnerdhair opened this issue Apr 26, 2022 · 0 comments
Labels
tech-debt A suboptimality that existed in code when it was written.

Comments

@mrnerdhair
Copy link
Contributor

Overview

In #524, we disabled a set of failing integration tests. The reference data for these TXes contain a zero-valued "fees" field, which is now omitted by proto-tx-builder. This change should be compatible, but we need the tests updated with new, on-chain, successfully-broadcast reference data.

References and additional details

See 25c1e1c for the disabled tests.

Acceptance Criteria

  • Tests are re-enabled and pass with freshly generated reference data
  • New reference data comes from TXes actually broadcast and successful on-chain

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrnerdhair