Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor xdefi issues #467

Closed
mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #423
Closed

minor xdefi issues #467

mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #423
Labels
tech-debt A suboptimality that existed in code when it was written.

Comments

@mrnerdhair
Copy link
Contributor

hdwallet-xdefi has a few miscellaneous issues:

  • There are a few typos
  • It imports all of lodash when only some is required
  • Its integration tests' mocks affect the environment of all other wallets' tests
  • It implements create()/info() functions which turn out to be unnecessary

AC:

  • Fix typos
  • Import only the lodash functions that are needed (i.e. lodash/isObject)
  • Put the mocks in __mocks__ and use jest's automock functionality to apply them when nessecary
  • Remove the create() and info() functions before anyone can get around to using them

Fixed by #423.
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Mar 14, 2022
@mrnerdhair mrnerdhair linked a pull request Mar 25, 2022 that will close this issue
minor xdefi improvements #423
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

minor xdefi improvements shapeshift/hdwallet
1 participant
@mrnerdhair