BTC(Input|Output)ScriptType
types are redundant
#465
Labels
tech-debt
A suboptimality that existed in code when it was written.
Milestone
There's only one type of script type, but we've got two different ones. This makes the API harder to use, the library as a whole less extensible and harder to maintain, and gives people the false impression that script type and address format have something to do with each other.
BTC(Input|Output)ScriptType
into a singleBTCScriptType
enum whose members represent the actual BTC script types.BTCAddressFormat
, to make specifying a specific script type to orthagonal to specifying how an address should be encoded (e.g.cashaddr
vs Bech32 vs Base58Check)defaultAddressFormatForScriptType()
tohdwallet-core
which returns the standard Bitcoin Mainnet address format used with each script type.Fixed by #434.
The text was updated successfully, but these errors were encountered: