remove DebugLinkWallet
#426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shapeshift/hdwallet/Cf3N6zgSDGr4jjJdTB9uAutCBgse |
|
Hmm.. needs update with the contents of d6650a4. Back to draft I guess. |
|
Nope, I lied, that was already merged in #367. Back to non-draft. |
|
checked axiom and platform-shared; they don't use this anywhere. looks to me like it was only ever actually used in the integration tests, which would make it an internal implementation detail. |
mrnerdhair
added
the
reopen-later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #418.
Removes the
DebugLinkWalletabstraction; #418 passes the precise type of wallet through so there's no need to introspect it to find out if it's got support anymore.