Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: conflict in prerequisites? #41

Closed
tagliala opened this issue Jan 29, 2022 · 3 comments
Closed

Readme: conflict in prerequisites? #41

tagliala opened this issue Jan 29, 2022 · 3 comments
Labels

Comments

@tagliala
Copy link
Contributor

Hi,

just noticed that as per prerequisites, shakapacker requires Rails 2.7+ and Ruby 5.2+, but Rails 5.2 does not officially support Ruby 2.7 rails/rails#38426

Should this be considered a conflict or an unsupported combination?

@tagliala tagliala added the bug label Jan 29, 2022
@tomdracz
Copy link
Collaborator

Good spot @tagliala !

Looks like requirement of Ruby 2.7 was introduced in rails/webpacker#3156 as it's the minimum that Rails 7 supports.

This indeed creates bit if discrepancy in the requirements. I think we've got 2 months left of Ruby 2.6 before EOL.

I'll open a PR, since we've pretty much dropped Rails 5.2 support with Ruby requirement change, we might as well update the docs and gemspec.

@tomdracz
Copy link
Collaborator

tomdracz commented Jan 30, 2022

Looking at this though, TECHNICALLY, Rails 5.2 doesn't discard 2.7 in the gemspec https://github.com/rails/rails/blob/5-2-stable/rails.gemspec This is why our tests running Rails 5.2 against Ruby 2.7 pass (although with deprecation warnings for kwargs).

So looks like you can still run this combo but you will at least be hit with bunch of depreciation warnings.

Considering the mismatch, Rails team position on this (officially unsupported) and EOL incoming, I think we should look at Rails 6 as minimum in one of the upcoming releases. Thoughts @justin808?

@justin808
Copy link
Member

Since the surface area of webpacker is small, we should support 5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants