-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator is not creating command to start hot reloading #277
Comments
@hafizio We've got plans to update the generators to match up with the https://github.com/shakacode/react-webpack-rails-tutorial/. If you or somebody you know could help with this, that would be much appreciated. |
@hafizio When you say "previously", are you saying that a prior version of ReactOnRails? |
@justin808 yes. I think before the version 3. Thank you for the quick response. |
Definitely sounds like a bit of a bug, but also something we'd need to find a volunteer to fix these generator issues. @yorzi Any chance you might be able to help us again on the generator? |
BTW, we're thinking of removing the hot-reload webpack dev server, as the new way allows you to simply use your Rails server for hot reloading. @jbhatab We really got to get this changed in the generators before you make your epic screencast series! |
Looks like it was removed in 2.0 |
@aaronvb We might have done this to simplify things. In general, it doesn't make sense to run more processes than you really need, as every change saved triggers lots of recompilation. |
@justin808 Further investigating, we moved the command to Perhaps we could update the base generator helpful message to include that command. We're only showing that command with the redux generator. |
@aaronvb Excellent idea! |
@hafizio While the hot command is no longer in the Procfile, it can still be loaded with |
Previously when I run
rails generate react_on_rails:install
. I'll have this in myProcfile.dev
:Now when I install again in a fresh application, the
hot
is missing and I have to add it manually. So runningforeman start -f Procfile.dev
won't start the server for hot reloading.The text was updated successfully, but these errors were encountered: