Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add generate_iframe_playlist option #205

Merged
merged 2 commits into from
Nov 11, 2024
Merged

feat: Add generate_iframe_playlist option #205

merged 2 commits into from
Nov 11, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 11, 2024

No description provided.

@avelad avelad force-pushed the generate_iframe_playlist branch 7 times, most recently from 85e47f1 to 1799252 Compare November 11, 2024 11:26
@avelad avelad force-pushed the generate_iframe_playlist branch from 1799252 to 5ad41ab Compare November 11, 2024 11:31
@mariocynicys
Copy link
Member

iframe_playlist_name: The optional HLS I-Frames only playlist file to create. Usually ends with ‘.m3u8’, and is relative to hls_master_playlist_output (see below). Should only be set for video streams. If unspecified, no I-Frames only playlist is created.

Quoting: https://shaka-project.github.io/shaka-packager/html/tutorials/hls.html

Seems like this should only be set for video output only.

@avelad
Copy link
Member Author

avelad commented Nov 11, 2024

iframe_playlist_name: The optional HLS I-Frames only playlist file to create. Usually ends with ‘.m3u8’, and is relative to hls_master_playlist_output (see below). Should only be set for video streams. If unspecified, no I-Frames only playlist is created.

Quoting: https://shaka-project.github.io/shaka-packager/html/tutorials/hls.html

Seems like this should only be set for video output only.

But I check the type of stream to make sure it is of the VIDEO type so that it only appears in the video.
imagen

@mariocynicys
Copy link
Member

But I check the type of stream to make sure it is of the VIDEO type so that it only appears in the video.

my bad, i should get glasses xD

mariocynicys
mariocynicys approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thanks

@avelad avelad merged commit 071396b into shaka-project:main Nov 11, 2024
18 checks passed
@avelad avelad deleted the generate_iframe_playlist branch November 11, 2024 18:06
@shaka-bot shaka-bot mentioned this pull request Nov 11, 2024
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jan 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mariocynicys mariocynicys mariocynicys approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @mariocynicys