Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloud): Avoid rate limit issues on live streams #162

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix(cloud): Avoid rate limit issues on live streams #162

merged 2 commits into from
Oct 23, 2024

Conversation

joeyparrish
Copy link
Member

To avoid rate limit failures (HTTP 429 "Too many requests"), avoid writing to the same file multiple times per second. This happens only on MPD and M3U8 files.

@joeyparrish
fix(cloud): Avoid rate limit issues on live streams
41060d5 
To avoid rate limit failures (HTTP 429 "Too many requests"), avoid writing to
the same file multiple times per second.  This happens only on MPD and M3U8
files.
@joeyparrish
Copy link
Member Author

With these settings, I'm seeing about 1/3 of our upload requests end up rate-limited. Of those, about 75% are the MPD and the other 25% are M3U8 files. After 50k upload requests, none returned 429 or 500.

@joeyparrish
Copy link
Member Author

Live stream running with this change:

https://shaka-player-demo.appspot.com/demo/#assetBase64=eyJuYW1lIjoiU2hha2EgSGlzdG9yeSAoREFTSCkiLCJzaG9ydE5hbWUiOiIiLCJpY29uVXJpIjoiIiwibWFuaWZlc3RVcmkiOiJodHRwczovL3N0b3JhZ2UuZ29vZ2xlYXBpcy5jb20vc2hha2EtbGl2ZS1hc3NldHMvcGxheWVyLXNvdXJjZS5tcGQiLCJzb3VyY2UiOiJDdXN0b20iLCJmb2N1cyI6ZmFsc2UsImRpc2FibGVkIjpmYWxzZSwiZXh0cmFUZXh0IjpbXSwiZXh0cmFUaHVtYm5haWwiOltdLCJleHRyYUNoYXB0ZXIiOltdLCJjZXJ0aWZpY2F0ZVVyaSI6bnVsbCwiZGVzY3JpcHRpb24iOm51bGwsImlzRmVhdHVyZWQiOmZhbHNlLCJkcm0iOlsiTm8gRFJNIHByb3RlY3Rpb24iXSwiZmVhdHVyZXMiOlsiVk9EIl0sImxpY2Vuc2VTZXJ2ZXJzIjp7Il9fdHlwZV9fIjoibWFwIn0sImxpY2Vuc2VSZXF1ZXN0SGVhZGVycyI6eyJfX3R5cGVfXyI6Im1hcCJ9LCJyZXF1ZXN0RmlsdGVyIjpudWxsLCJyZXNwb25zZUZpbHRlciI6bnVsbCwiY2xlYXJLZXlzIjp7Il9fdHlwZV9fIjoibWFwIn0sImV4dHJhQ29uZmlnIjpudWxsLCJleHRyYVVpQ29uZmlnIjpudWxsLCJhZFRhZ1VyaSI6bnVsbCwiaW1hVmlkZW9JZCI6bnVsbCwiaW1hQXNzZXRLZXkiOm51bGwsImltYUNvbnRlbnRTcmNJZCI6bnVsbCwiaW1hTWFuaWZlc3RUeXBlIjpudWxsLCJtZWRpYVRhaWxvclVybCI6bnVsbCwibWVkaWFUYWlsb3JBZHNQYXJhbXMiOm51bGwsInVzZUlNQSI6dHJ1ZSwibWltZVR5cGUiOm51bGx9

@joeyparrish joeyparrish requested a review from theodab October 23, 2024 03:30
mariocynicys
mariocynicys approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

streamer/proxy_node.py Outdated Show resolved Hide resolved
@joeyparrish
Copy link
Member Author

Updates appear to be working. Thanks for the review!

@joeyparrish joeyparrish merged commit 1231502 into shaka-project:main Oct 23, 2024
2 checks passed
@joeyparrish joeyparrish deleted the proxy branch October 23, 2024 18:50
@shaka-bot shaka-bot mentioned this pull request Nov 6, 2024
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Dec 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mariocynicys mariocynicys mariocynicys approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyparrish @mariocynicys